[4.x] Fix Checks#1709
Conversation
pest-plugin-browser ^4.3.1 requires pestphp/pest ^4.4.5 on the root package. Without an explicit version, Composer infers dev-<branch> on PR branches, which fails composer update before tests run.
|
Hey @nunomaduro 👋 Does this change make sense to you? I noticed checks failing on my earlier PR and I believe this is the fix needed. |
| { | ||
| "name": "pestphp/pest", | ||
| "description": "The elegant PHP Testing Framework.", | ||
| "version": "4.7.0", |
There was a problem hiding this comment.
With this fix, we need to update the version here with each update, no?
There was a problem hiding this comment.
Yeah, of course, open to other suggestions on how to fix this. But we should have running CI checks before merging PRs
There was a problem hiding this comment.
Thought of a better way of doing this actually
There was a problem hiding this comment.
Ha, you're PR does what I was thinking 😆
There was a problem hiding this comment.
@MrPunyapal Given this PR is smaller and fixes this one thing, I think it makes sense to fast-track getting this branch merged and then you can update yours.
What do you think?
|
This will also need an approval by @nunomaduro |
2 participants
What:
Description:
After pest-plugin-browser was raised to
^4.3.1(e766825f), PRs from branches not named4.xfail at composer update because the root package is inferred asdev-<branch>, which does not satisfy pest^4.4.5. Setting the root version unblocks CI for all PRs targeting4.x.